Meeting Summary:
The meeting focused on reviewing and discussing various PRs (pull requests) for the Ethereum RPC (Remote Procedure Call) specification. The team reviewed several PRs including one from Chase that was ready for merge after resolving a spell check failure, a PR from Manuel that added missing ATH GET-through transactions and was blocked by a GoEthereum PR, and a PR from Boma regarding transaction filtering that required further investigation. Felix provided guidance on handling Amsterdam fork-related changes, explaining that new features for upcoming forks should be added to the schema without tests initially, and suggested creating a tracking issue for spec changes without tests. The team also discussed a long-standing issue about error code grouping, where Simson expressed concerns about proposed changes that might not be compatible across different EVM clients, and Felix mentioned that Sina is working on a comprehensive proposal for error codes that would use strictly positive numbers to distinguish new error codes from legacy ones.
Click to expand detailed summary
The team discussed several pull requests, with Chase confirming that one of his PRs was ready for merge except for a spell check failure that was already fixed. Manuel explained his PR which adds missing ATH get-through transactions that mirror existing specifications, noting that it depends on another PR from the execution API team to be merged first. Felix joined the meeting partway through and agreed to rerun the CI for one of the PRs after being informed that all client teams had merged their necessary changes except for Etherex.
The team discussed a PR for adding slot numbers to the schema, which is intended for the Amsterdam fork. Felix clarified that while the feature doesn’t need immediate approval, it requires implementation in clients and should be added to the schema. The team agreed to mark the PR for the Amsterdam fork and noted that tests would need to be added later once the Amsterdam spec is finalized, rather than regenerating the test chain with each specification change to avoid overhead.
The team discussed several PRs and changes, with Felix confirming he had launched CI and would approve a PR that needed additional testing for wildcard matching functionality. Manuel presented a change adding three missing endpoints (ATH, GET, ROADS, and SACH) which is blocked by a GoEthereum PR and requires merging that PR along with pinning a new release and regenerating tests. The team also reviewed a PR that fixes linting tool issues related to empty errors, with Felix explaining they would update the spec generator to emit an empty list when there are no errors in the YAML.
The team discussed merging two pull requests (PRs 802 and 797) related to changes in regular expressions for decimal numbers and byte patterns. Felix expressed uncertainty about the first change in PR 802 and needed to investigate further, while Chase confirmed that PR 797’s tests were passing and the spec updates had been merged, making it ready for merging. The team agreed to proceed with merging both PRs after confirming the necessary specifications were in place.
The team discussed reviewing and merging a PR for GoEthereum that was marked as directionally correct but requiring detailed review. Felix explained that while the PR is fine, it needs someone to spend time reviewing it thoroughly, similar to other changes in GoEthereum. The team also discussed a method that returns true regardless of peer status, with Chase suggesting it could be marked as spec-only or have its tests removed since it doesn’t provide meaningful functionality.
Chase reported that their PR for the state method had a green status in the CI after force pushing. Felix discussed merging the PR and shortening the title. Boma raised questions about closing old PRs, specifically mentioning PRs 353 and 331, and suggested discussing the implementation of an index feature in a wider forum due to its complexity and potential limitations for non-archive nodes.
The team discussed error codes grouping, with Simson advocating for maintaining a generalized approach rather than client-specific categorization to ensure consistency across different EVM chains. Felix explained that Sina is working on a comprehensive proposal that would use strictly positive error codes to distinguish new reliable errors from legacy errors, with a transition period allowing clients to map between old and new codes. The group agreed to continue discussions on the proposal, potentially taking it to the EAC for broader input, while Boma raised a follow-up question about the implementation of debug execution witness across different clients that Chase indicated needed further investigation.
Next Steps:
- Felix: Rerun CI for PR81.4 and merge it once CI is green.
- Felix: Approve and merge Chase’s PR for the state method (CI is now green).
- Felix: Review and investigate the first part of the diff in PR 802 (regarding byte pattern).
- Felix: Schedule review and merge of the GoEthereum PR (35227) for the ETH get raw transaction by hash, which is blocking Manuel’s PR.
- Boma: Open an issue in the repo regarding the debug execution witness implementation and tag the relevant people (e.g., Kev) for input.
- Felix: Create a tracking issue to document all spec changes made for the Amsterdam fork without adding tests, or consider keeping a long-running Amsterdam branch for future forks.
- Felix: Update the spec generator to emit an empty list for errors when none are defined in the YAML, as discussed in PR 81415.
- Felix: Recheck PR 797 in light of the updated OpenRPC spec version to determine if it can now be merged.
- Boma: Close old PRs 353 and 331, as they have been matched or superseded by other PRs.
Recording Access: