Meeting Summary:
The ROPC Core Standard 28 meeting focused on reviewing multiple pull requests and discussing the release process for versioning. The team reviewed several PRs including #353 which had been addressed in a different PR and was marked as spam, while PR #795 was ready for merge once CI testing passed. A significant discussion centered around error codes implementation, with Felix and Chase agreeing that using eSimulate error codes as canonical codes was the least disruptive approach despite some concerns about standardization. The team also discussed PR #801 which was pending Nethermind client fixes, and Felix committed to reviewing a large PR related to memory bloat issues. The conversation ended with discussions about a Hive deposit contract address issue and the need for Aragon team sign-off on filled transaction changes, with the team agreeing to fix the Hive configuration issue before proceeding with their first release.
Click to expand detailed summary
Boma led a meeting about ROPC Core Standard 28 and discussed a recent release related to versioning. The team addressed concerns about Felix’s availability for reviewing pull requests, with Chase noting that Kerry could handle PR merges if Felix’s review wasn’t required. Boma requested Carrie to provide an introduction about the release process and address a comment on Discord regarding the recent changes.
Kclowes discussed the release and documentation work completed by Zane’s team, which now includes multiple versions including 1.0.0 beta 7. Boma suggested potentially making an announcement when moving out of beta, though there was some confusion about previous discussions regarding this. The team identified several pull requests that need to be addressed, including one that has been resolved and another marked as spam, with error codes being discussed as a remaining open item.
The team discussed issue 817 regarding error codes for the execution-apis specification. Felix and Chase agreed that using eSimulate error codes as canonical codes was the least disruptive option, despite some concerns about the quality of these codes. Tullio from Aragon supported moving forward with defining error codes. Chase committed to follow up with Sina and Samsung to reach a compromise on the error code specification.
The team discussed several pull requests and their status. For PR 795, kclowes confirmed they could kick off CI testing. PR 801 is pending Nethermind’s resolution of a regression issue before moving forward. Felix committed to reviewing PR 762, which contains over 1,000 lines mostly consisting of tests. The team also discussed PR 830 regarding HiveChain configuration, where Felix explained that regenerating the test chain would resolve the deposit contract address issue. Boma noted that PR 831 was blocking Sina’s work and needed conflict resolution.
Felix and Boma discussed merging a PR that updates the schema version, which Boma confirmed could proceed after addressing Sinner’s PR. They also reviewed a filled transaction PR that removes raw transaction ROP output to prevent potential mismatches, with Tullio indicating general support pending review and Ergon’s approval. The team noted the need to discuss the changes with Nethermind since they raised original concerns about the issue.
The team discussed bringing additional stakeholders into a call to agree on a proposal, with Boma offering to tag a team member like Lucas to follow up. Chase updated the group on a default block parameter change that has been merged by all clients except Aragon and Etherex, requesting Tullio to review it. The team agreed to proceed with their first release after fixing the hive deposit contract issue, rather than waiting for the Amsterdam event.
Next Steps:
- kclowes: Kick off CI for PR 795 and merge it once CI is green.
- Chase: Talk to Sina and Simpson to reach a compromise on error codes (Issue 817) and work on it asynchronously.
- Felix: Review the large PR (likely 795) today, focusing on the spec and tests.
- Felix: Investigate and resolve the HiveChain deposit contract address issue in the relevant PR.
- Boma: Tag a Nethermind team member (e.g., Lucas) to get their sign-off on the “fill transaction” PR.
- Chase: Mark the “default block param to latest on state methods” PR as ready for review/merge.
- kclowes and Chase: Decide on the timing for the first official release (v1), considering fixing the Hive deposit contract issue first.
Recording Access: