The team reviewed multiple PRs and issues during their standards call, including updates on error codes, authorization schema extensions, and a new storage batch method implementation. They discussed a resource availability API endpoint and debated different approaches to implementing and documenting this functionality. The conversation ended with decisions on API standardization and discussions about CI testing issues that require further investigation.
Click to expand detailed summary
The team discussed several PRs and issues during their standards call. Simsonraj provided an update on error codes, mentioning that the PR had been modified to use new Go tooling and validated functionality. Felix approved the changes and said he would review the output after the call. The team then reviewed PR 761, which Chase noted was technically approved but required additional context from Felix. They also discussed a potential extension to the authorization schema for unsigned authorizations in EIP 77702, though Felix noted this wasn’t a pressing issue. The conversation ended with a brief mention of the GetStorageValues method added in GetH, with Sina having regenerated the tests.
The team discussed two main topics: a new storage batch method and an allow zero save block feature. For the storage batch method, Chase explained his initial concerns about batch calls but now supports the implementation as it removes the need for JSON RPC patch calls. The team agreed to merge the PR, though they noted the need for clearer documentation in the spec regarding the non-empty request requirement. Regarding the allow zero save block feature, the team decided to defer the decision to the Engine API team, with Chase and Sina agreeing to discuss it further, particularly seeking Felix’s opinion as a Geth core developer.
Felix and Sina discussed the implementation of an API endpoint to determine the availability of resources on a node. Felix expressed concerns about the current approach of using deletion strategies and window retention, suggesting it might be too complex and not capture all nuances of data availability. Sina explained the current model focuses on defining common resources between nodes and clients, allowing users to understand what data is stored. They agreed that more documentation is needed to explain the impact of resource availability on API functionality. The discussion concluded with a suggestion that a subscription-based approach could be more effective for providing real-time updates on resource availability, though this would require further discussion with other stakeholders.
The team discussed several PRs and API specifications. They agreed not to standardize the txpool inspect method, with Felix arguing it was a legacy debugging method that shouldn’t be part of the public API. Tullio suggested moving it to a private namespace instead. The group also reviewed some easy-to-merge PRs including one requiring only a one-line change. Felix and the team identified an issue with CI not properly failing tests when modifications are made to test files, which they agreed needs further investigation.
Next Steps:
Simsonraj: Address Mercy’s two comments on the error codes PR (validation for overlapping ranges and error wrapping format)
Simsonraj: Update error codes PR with fixes today or tomorrow
Felix: Review the error codes PR output after the call
Mercy: Ping Felix to review the error codes PR
Chase: Ask LightClient to review the error codes PR if he has time
Tullio: Review Chase’s new PR on EIP 3155 and provide feedback
Erigon team (Tullio): Search issue tracker for requests related to authorization list feature and comment on issue if found useful
sina: Add comment to PR 761 explaining that empty request should not be allowed for GetStorageValues method
sina: Add documentation text to the spec for GetStorageValues method clarifying the empty request constraint
Felix: Merge PR 761 (GetStorageValues method)
sina: Write concrete feedback on ETH capabilities PR based on Felix’s suggestions (renaming trynodes to state proof, adding head block, considering subscription approach)
Felix: Investigate why CI is not failing when tests are modified without generator updates
Felix: Verify locally if tests change on main branch for PR 763
sina: Update PR 763 if tests require further changes to make it repeatable
Mercy: Remove txpool inspect method from PR 758 based on discussion
Geth team (Felix): Move txpool inspect method to a Geth-specific namespace instead of standardizing it
Tullio: Consider moving Erigon-specific methods to Erigon namespace for clarity