Discussion for Add EIP: eth/XX - announce transactions with nonce by cskiraly · Pull Request #10745 · ethereum/EIPs · GitHub
This EIP improves mempool propagation, extending the devp2p ‘eth’ protocol’s NewPooledTransactionHashes message to also announce each transaction’s source address and nonce together with the already announced hash, type, and size.
By making this change, EL clients will be able to:
- filter by source,
- fill nonce gaps more efficiently,
- avoid some useless transaction fetches.
@etan-status @raul I’ve discussed with both of you the option of including fees besides the source and nonce in the announcement. I’ve now added some text about it in the rationale, but not (yet) in the selected solution. Let’s discuss whether to change the proposed version to one that includes fees as well.
1 Like
I’m changing the EIP to have the version announcing fees as well discussed more and selected as the main proposed solution. So what’s announced are: txhash, type, size, source, nonce, fees
I feel like if we do this (sender and nonce) we should also directly encode the upfront cost of this transaction (so this is the min balance the sender needs to have). This allows clients to efficiently probe the txpool. If we want to save data, we can also round this up (or down) by a constant, e.g. 1e9 to get rid of those not super-important bytes. The downside is that some txs which spend the entire balance of that account might not propagate through the network because the client sees it is too close to the boundary, so it might not have enough funds (off by a very small number of no actual value) to fund it.