Discussion topic for EIP-7799 EIP-7799: System logs
Update Log
External Reviews
None as of 2024-10-29.
Outstanding Issues
2 Likes
This is a very interesting EIP especially in combination with 7708.
Here is some general feedback:
- EIP lists 7708 as required but this is technically not required, so I suggest to remove it
MAX_LOGS_PER_RECEIPT
is necessary for the SSZ type but it is not defined anywhere. NVM this is part of EIP 6466
- Why is the priority fee not credited to coinbase as-is? I understand that this is a transfer which is not logged anywhere, but it can be deduced from every tx in combination with the logs. From
cumulativeGasUsed
(together with previous receipt) the gas used can be deduced, and the priority fee can be calculated from the tx. So the data is there to calculate this. Alternatively, these priority fee logs could also be inserted after each tx into the system_logs
. This will not “change” the behavior of the EVM which I think is an undesired side effect of this EIP (block coinbase does not collect fee during block, but now only after the block has been executed will it receive fees). But this would require all that data as opposed to adding this to the logs. (Then only log data is necessary). EDIT: ok this is motivated a bit more in the Alternatives/Future section
- For clarity, I think the
data
fields of the eth-transfering events should just be encoded as uint
? It should be a representation of bytes which does not have leading zeros in the log.
- Why must the log be added to a genesis block if the EIP is used from the beginning? This will be clear because there is a
system_logs_root
field, so there is no need to add this log there in the genesis block
block_header.system_logs_root = system_logs.hash_tree_root()
it is not mentioned how the hash tree root should be calculated
- “Batched crediting of priority fees improves parallel execution of transactions, as a transaction can no longer start with insufficient fees”. I don’t see how it was previously possible to start a transaction with insufficient fees (this is not possible)
1 Like
Disregard my previous post, should first read 6466 in-depth before raising these points