EIP-5058: ERC-721 Lockable Standard

EIPs
1

Keywords: Lockable, non-fungible tokens, NFTs, ERC-721

This standard makes NFTs more suitable for NFTFi, such as locking, staking, lending, crowdfunding, etc.

2

Hi,

EIP-5192: Minimal Soulbound NFTs is not final and features similar functionality albeit without an approval function for locking.

3

How can I write the smart contract code for ERC 721 implementing EIP 5058?
Is there any source code?

1 Like
4

IMO this almost the perfect SBT standard to date if it was slimmed down a bit (it is potentially already better than my attempts EIP-5192 and EIP-4973) The name “Lockable tokens” is also very good. Here’s what would make it golden:

  • Focus on Lock and lock approval
  • remove the expiry feature as it doesn’t directly map to EIP721 transfer+transferapprove (could be optional)
  • make boundNFT an optional extension
  • clearly state in the Specification section that when the function locked returns true, what the other functions then have to return (e.g. that transfers have to throw etc). Allow no undefined behavior in the spec (here’s how that could look: ERC5192/ERC5192.t.sol at main · attestate/ERC5192 · GitHub (I didn’t do a great job in EIP-5192 admittedly).

Then in security section, I’d also add:

  • If a token implements EIP-5058 and then there exists a vault contract that e.g. allows to do a trade of: “I lock token, you give me 1 ether. I unlock token when you give me 1 ether back”, then the vault contract must allow listing the EIP-5058 token as purely relying on the interface of a contract isn’t prove that the contract correctly implemented EIP-5058. But IMO this is already fairly standard with EIP-20 etc., so I think it’s not a deal breaker with EIP-5058
5

I like this interface. I don’t like, however, when we — the development community — is forced to choose between similar interfaces. So, I would suggest a change.

If instead of

interface IERC5058 {
  event Locked(address indexed operator, address indexed from, uint256 indexed tokenId, uint256 expired);
  event Unlocked(address indexed operator, address indexed from, uint256 indexed tokenId);
  event LockApproval(address indexed owner, address indexed approved, uint256 indexed tokenId);
  event LockApprovalForAll(address indexed owner, address indexed operator, bool approved);
  function lockerOf(uint256 tokenId) external view returns (address locker);
  function lock(uint256 tokenId, uint256 expired) external;
  function unlock(uint256 tokenId) external;
  function lockApprove(address to, uint256 tokenId) external;
  function setLockApprovalForAll(address operator, bool approved) external;
  function getLockApproved(uint256 tokenId) external view returns (address operator);
  function isLockApprovedForAll(address owner, address operator) external view returns (bool);
  function isLocked(uint256 tokenId) external view returns (bool);
  function lockExpiredTime(uint256 tokenId) external view returns (uint256);
}

You extend ERC5192 — which is in the final stage and will most likely be used in standard contracts — and change the code as

interface IERC5192 {
  event Locked(address indexed operator, address indexed from, uint256 indexed tokenId, uint256 expired);
  event Unlocked(address indexed operator, address indexed from, uint256 indexed tokenId);
  function locked(uint256 tokenId) external view returns (bool);
}

interface IERC5058 is IERC5192 {
  event LockApproval(address indexed owner, address indexed approved, uint256 indexed tokenId);
  event LockApprovalForAll(address indexed owner, address indexed operator, bool approved);
  function lockerOf(uint256 tokenId) external view returns (address locker);
  function lock(uint256 tokenId, uint256 expired) external;
  function unlock(uint256 tokenId) external;
  function lockApprove(address to, uint256 tokenId) external;
  function setLockApprovalForAll(address operator, bool approved) external;
  function getLockApproved(uint256 tokenId) external view returns (address operator);
  function isLockApprovedForAll(address owner, address operator) external view returns (bool);
  function lockExpiredTime(uint256 tokenId) external view returns (uint256);
}

The only change is that the function isLocked is renamed locked. That will of course change the interfaceId, but since it is in a draft stage, it would make a lot of sense and would also facilitate the approval of EIP 5058.