Hi everyone, this is the discussions issue to discuss the newly propose EIP regarding Multi-Fractional Non-Fungible Token Standard.
EIP-4675
This EIP was proposed to minimize redundant bytecode on the Ethereum blockchain by not having to deploy ERC-20 contract every time when fractionalizing an NFT.
EIP-4675 is similar to the ERC-1155 token regarding _id distinguishing each token type, but different since each _id represents a distinct NFT.
By calling setParentNFT() the contract verifies the ownership of NFT and adds a new token type.
This is the reference implementation with a full-coverage test.
Implementation
Please, share your thoughts freely.
Thank you.
1 Like
Is there a front-running concern with setParentNFT?
For example, I send CoolNft #442 to the MFNFT contract, then I call setParentNFT(CoolNft, 442, 100).
Before my transaction is included, some third party calls setParentNFT(CoolNft, 442, 1).
Would it make more sense to write this EIP as a direct extension of EIP-1155?
interface MFNFT is IERC1155 {
/**
@notice Sets the NFT as a new type token
@dev The contract itself should verify if the ownership of NFT is belongs to this contract itself with the `_parentNFTContractAddress` & `_parentNFTTokenId` before adding the token.
MUST revert if the same NFT is already registered.
MUST revert if `_parentNFTContractAddress` is address zero.
MUST revert if `_parentNFTContractAddress` is not ERC-721 compatible.
MUST revert if this contract itself is not the owner of the NFT.
MUST revert on any other error.
MUST emit `TokenAddition` event to reflect the token type addition.
@param _parentNFTContractAddress NFT contract address
@param _parentNFTTokenId NFT tokenID
@param _totalSupply Total token supply
*/
function setParentNFT(address _parentNFTContractAddress, uint256 _parentNFTTokenId, uint256 _totalSupply) external;
/**
@notice Get the bool value which represents whether the NFT is already registered and fractionalized by this contract.
@param _parentNFTContractAddress NFT contract address
@param _parentNFTTokenId NFT tokenID
@return The bool value representing the whether the NFT is already registered.
*/
function isRegistered(address _parentNFTContractAddress, uint256 _parentNFTTokenId) external view returns (bool);
}
That’s a good point. To prevent front-running issue the reference implementation includes onlyAdmin() modifier to only let the admin call the setParentNFT(). I also agree that notifying developers to consider front-running issues is a must!
The only point of sameness with ERC-1155 is that this token standard uses _id to distinguish different token types. This token standard includes NFT ownership verification and many other features to receive and fractionalize the NFT.
So, I considered it better to be a separate token standard.
Interesting. I assumed the owner who deposited the NFT would initially receive all of the fractionalized tokens and get to set the totalSupply, not an admin.
I’m not sure what you mean exactly. Doesn’t the MFNFT also inherit all the functions for transferring, querying balance, etc?
In my opinion just have an extension to ERC-1155 as suggested by @SamWilsn
The simpler, the more chance for adoption. There’s a whole bunch of duplication to ERC-1155 anyway, like the transfer functions and balances of multi tokens etc.