Hi everbody!
Created this ERC for redeemable tokens as a part of a school assignment. Would love any feedback / criticism.
Hi will this proposal be merged into the main repository under draft stage?
Once the review process finishes, yes, probably.
Token standards generally don’t define functions like setMaxSupply, setBatchMaxSupplies, setPrice, setBatchPrice, or even mint because these operations are generally only controlled by the same entity that deployed the token contract. Generally, EIPs only exist to coordinate between multiple parties.
I’d recommend either removing functions from the standard that are only ever called by the contract owner, or adding some justification to your Rationale section explaining why these functions need to be standardized.
On another note, I believe that removing the transfer family of functions will lead to a much worse user experience than ERC-1155 with transfer functions that revert.
With standard transfer functions (that always revert) a user can try to transfer, and receive a useful error message when it fails. Most wallets won’t even try to put a reverting transaction on-chain.
On the other hand, without standard transfer functions, how does the wallet even know if it should display UI elements for a transfer? That’s a whole other ordeal.