Meeting Summary:
The team discussed issues with the Execution API spec check, focusing on schema mismatches between expected object types and actual array outputs in test cases and specifications. They explored potential solutions, including modifying schemas to accommodate both object and array cases, and identified the need to update the YAML schema for Ethereum simulate results. Additionally, the team addressed CI configuration problems causing pull requests to fail checks after merging to master, and agreed to continue discussions on Discord regarding specification updates for the EthSimulateBlockResultSuccess schema.
Click to expand detailed summary
Mercy reported an issue with the Execution API spec check, where an array is causing CI failures. The team discussed whether modifying the schema to include both an object and an array would be acceptable, though Micah and Killari expressed uncertainty about making such changes. Mercy shared a PR and screen to demonstrate the problem, which Micah confirmed could be investigated further.
The team discussed an issue with test cases and specifications where the test was failing due to an expected output type mismatch in the schema. Mercy explained that the problem arises from multiple block state calls being bound into a response as an array, which conflicts with the spec that requires a single object type. Micah and Killari clarified that while some test cases might not have valid outputs, error responses should always be valid according to the specification.
Mercy and Micah discussed a schema issue where the result was expected to be an object but was outputting as an array. They examined the execution-apis repo to understand the correct schema specification, with killari providing guidance on where to find the relevant components under the schemas section. The discussion focused on aligning the schema to properly handle both object and array cases.
The team discussed an issue with the YAML schema for Ethereum simulate results, where the schema incorrectly specified that results should be an object when they should be an array. Micah explained that the correct schema should define two cases: one for successful results (containing a result array) and another for errors (containing an error object). Kalari agreed to update the YAML schema to reflect this, using references to the existing successful and error cases.
Micah and the team discussed an issue where pull requests (PRs) were failing to pass CI checks only after being merged to master, not during the initial submission. Micah hypothesized that the CI configuration was incorrectly set up to run against the master branch instead of the PR branch, which could happen if the CI process accidentally clones the head instead of the PR. Micah suggested this was likely a configuration issue with the CI setup, and he was investigating the problem further.
The team discussed a specification issue in the EthSimulateBlockResultSuccess schema, where Micah clarified that the result property should be an array while the error property should be an object, and objects can only have one of these properties. Micah agreed to mention this to Laurie and Jason in the JSON RPC API Discord channel, and suggested that Mercy could test the fix after it’s implemented. The team decided to continue the discussion on Discord and planned to follow up next week.
Next Steps:
- Killari to submit a pull request with the corrected YAML schema for eth_simulate results in the execution API spec.
- Micah to review Killari’s pull request for the YAML schema correction.
- Micah to follow up with Light Client on Discord regarding the CI configuration issue.
- Mercy to monitor the progress of the schema correction and CI issue resolution.
Recording Access:
- Join Recording Session
- Download Transcript (Passcode:
P&?5KTiY) - Download Chat (Passcode:
P&?5KTiY)