ERC-7579: Minimal Modular Smart Accounts

ERCs
21

Thanks for spotting this. We renamed supportsAccountMode to supportsExecutionMode but seems like we forgot to change this occurrence. Should be fixed now

22

Would using ERC-7746: Composable Security Middleware Hooks instead of built in hooks be useful to encapsulate some of the functionality of this ERC?

23

Whats the upside here? There are around 6 ERC-7579 hooks already in prod and more being developed atm and 5+ accounts using these hooks with the interfaces. Also many hooks will decode the calldata to see what executions are doing so they will anyways need to be aware of ERC-7579 interfaces

24

Interoperability, encapsulation of specifications, kind of makes sense for me that this had to be figured out before doing 4337 (also has hooks for paymaster validation) and 7579… but it wasn’t, so Im proposing.

25

Heads-up that the return value of executeFromExecutor is not documented. Although it seems obvious that it’s the array of return data resulting from execution, I don’t think it hurts to specify.

I’d suggest:

/**
 * @dev ...
 * ...
 * @return returnData An array with the returned data of each executed subcall
 */
function executeFromExecutor(
    bytes32 mode,
    bytes calldata executionCalldata
) external returns (bytes[] memory returnData);

All other return values seem to be already specified, though

26

good shout - thanks! updated this here: Update ERC-7579: specify executeFromExecutor return data type by kopy-kat · Pull Request #736 · ethereum/ERCs · GitHub

1 Like