Hi,
I’m glad to see this moved through! We’re a bit slower with the Asset-Bound NFTs (ERC-6956), as it’s a quite complex proposal.
ERC-6982 duplicates essentially parts of the mechanics of our optional IERC6956Floatable interface, in particular the events FloatingStateChange, FloatingAllStateChange.
To avoid standard-duplication and also motivate external platforms (e.g. OpenSea) to implement interfaces, I’m inclined to drop our two events from IERC6956Floatable and RECOMMEND implementing ERC-6982 together with IERC6956Floatable. I think this could also be included in the Full reference implementation of ERC-6956 (which implements all optional interfaces).
The logic would be:
- Implement Events from ERC-6982 instead of
FloatingStateChange,FloatingAllStateChange locked(tokenId)returns!floating(anchorByToken(tokenId))defaultLocked()is implemented additionally.
Questions
- Do you see any conflicts between ERC-6956 and your ERC-6982?
- This marries IERC6956Floatable somewhat to ERC-6982, although ERC-6956 cannot formally list ERC-6982 as required for ERC-6956, since only an optional extension is affected. Anybody seeing issues with this?
Thanks!