EIP Editing Office Hour (EIP + ERC) Meeting #87

The Ethereum Improvement Proposal (EIP) Editing Office Hour meeting focused on reviewing pull requests and discussing various EIP-related updates. Editor Sam Wilson and Pooja reviewed several proposals, including EIP 4361 for wallet auto-login, EIP 1965, and contribution guidelines for EIPs. They addressed issues with link references, author approvals, and the distinction between EIP statuses and network upgrade stages. The team also discussed updates to the contribution guidelines and style guide, with plans to add context for AI models. They identified and banned a suspicious user who had submitted numerous inappropriate pull requests. The conversation ended with a review of several other EIPs, including discussions about malicious web content and on-chain metadata for token registries.

Next steps

Summary

EIP Pull Request Review Meeting

The meeting focused on reviewing pull requests for EIP and ERC repositories, with editor Sam Wilson participating. Pooja explained that the call would not be streamed due to technical issues, and they would upload the recording later. The team discussed a force merge that was already approved but couldn’t be merged, with Sam agreeing to investigate the issue. They reviewed a proposal about royalty distribution for referral NFTs and a configurator role, noting some changes that had been made.

Ethereum Wallet Auto-login Pull Request

Sam and Pooja discussed a pull request related to wallet auto-login functionality for Ethereum sign-ins. They reviewed changes including a local allowlist for automatic signing of ERC-4361 messages, with policies managed by the wallet or user. The discussion concluded with agreement on a merge date of February 17th, noting that another related pull request had already been merged successfully.

Wallet Auto-login Standards Discussion

The discussion focused on wallet user interface standards, particularly around auto-login authorization flows and domain policy implementation. Sam discussed a technical specification for wallet auto-signing when specific domain conditions are met, and mentioned a bug related to backtick syntax in code fencing. The conversation also touched on cookie handling rules between parent and subdomains, though the exact terminology for this concept remained unclear.

AI Implementation and Wallet Features

Sam and Pooja discussed the implementation of AI responses and wallet UI features, focusing on user control and default policies for popular applications. They reviewed the rationale for signing with Ethereum and noted that HTTPS should be used for communication. Sam mentioned that they would follow up on certain points later.

EIP Website and Guidelines Update

Sam and Pooja discussed the status of EIP and ERC website links, confirming that only eips.etherthereum.org is functional, and agreed to maintain the EIP prefix for references despite the ERC website being non-functional. Pooja reported incorporating feedback from Sam and Johan into the contribution guidelines and style guide, which will be revisited after community review.

Documentation Updates for AI Models

Sam and Pooja discussed improvements to documentation files, including adding context for AI models in claude.md and agent.md files to help with EIPs. They identified a need to update the file name from contribute.md to contributing.md, following the same capitalization as README. Pooja mentioned that they would share the updated file with the community and continue making improvements, while Sam agreed to the changes and noted that similar updates would be needed for the ERC repo.

Draft Status Update for Ethereum

Sam and Pooja discussed changes to the draft stage conditions for final and living statuses in eips.ethereum.org. They agreed to remove the draft status for these categories and update the code to reflect this change. Pooja will implement the suggested updates, and Sam will review the output. They also briefly touched on the topic of tailoring renaming and Creed nomenclature, but no decisions were made on these topics.

EIP Document and Review Process

Pooja discussed an informational EIP and mentioned removing links to upcoming proposals to prevent the document from becoming too extensive. She clarified that the EIP does not recommend future actions but rather summarizes past efforts. Sam confirmed that Tim had created a meta-EIP containing several links, which Pooja used for her document. They also discussed a PR issue where the bot only pinged one author due to GitHub username limitations, and Sam explained that a comment does not count as an approval, clarifying the review process for Pooja.

Network Upgrade and EIP Stages

Sam and Pooja discussed the importance of distinguishing between network upgrade stages and EIP statuses in a proposal, with Pooja suggesting replacing the term “status” with “stages” where appropriate. They reviewed several pull requests and issues, identifying and addressing concerns related to a problematic user who had been banned from Ethereum repositories. Sam agreed to open and close relevant issues to manage the situation effectively.

Code Review and Documentation Updates

The team discussed several pull requests and code changes, with Pooja explaining that some items were already addressed in Nixon’s new PR. Sam and Pooja reviewed documentation updates, including the need to fix links and add rationale for parameter changes. Premm.eth made changes to the minimal token registry and minimal agent registry, fixing copyright issues and removing confusing statements. The team agreed to merge several pull requests after addressing outstanding comments, particularly from Johan.