That sounds like the loupe functions are actually somewhat optional then? I guess if an owner removes the loupe functions, the diamond is no longer a diamond until the owner re-adds them?
Yes, it is technically no longer a diamond without the loupe functions.
I’d rather keep the discussion here, if that’s alright. This is where we do most EIP discussion.
Sounds good and makes sense.
I believe you can call a contract with no calldata, and it executes the fallback function? Seems odd to prohibit that without a good reason.
Yes, you have a good point. I think you are right and the rule that prohibits that should be removed. I think this can be removed without disruption. It is arbitrary and I don’t think it would break anything to remove it. Thanks for pointing this out.
I’m just here doing my best to give feedback before the last call deadline EIPs should propose the best version of themselves, and not be beholden to existing implementations. That said, I do completely understand that EIP-2535 has been stable for some time and that most of my suggestions are terrible!
Make sense and I agree with you. I don’t think your suggestions are terrible. I like your suggestion for the loupe functions, but I don’t think the loupe functions should change at this point. I much appreciate your review and feedback concerning the standard and related parts. It was this kind of attention and feedback that really helped develop the standard in the first place, as can be seen from past discussions of it. And more attention and thought about things is beneficial.
I am really happy and appreciate that you are digging into this standard and I want to help you understand it and related things as much as I can. And I understand that part of that can also be figuring out how things should and should not be for yourself. I am a big proponent of people looking, figuring out, understanding and discovering things for themselves rather than just accepting what someone else says.